[Okular-devel] Review Request 116578: Add keyboard shortcut for 'search previous' action.

[Albert Astals Cid]

> On March 4, 2014, 12:09 a.m., Albert Astals Cid wrote:
> > This was already implemented, sorry we forgot to close the bug.
> 
> Swarn Kumar wrote:
>     Yeah, you should have. It took me an hour.
> 
> Albert Astals Cid wrote:
>     No, you should have tried if it worked before you did anything. First lesson learned, don't assume a bug exists just because someone filed it, check first.
> 
> Swarn Kumar wrote:
>     Am new to KDE hacking and I don't know but why would someone file a bug, if it isn't there?

 a) People suck
 b) The bug was reported and someone that didn't know the bug existed fixed it independently
 c) Others


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116578/#review51845
-----------------------------------------------------------


On March 4, 2014, 12:09 a.m., Swarn Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116578/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 12:09 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 328576 and Bug
>     http://bugs.kde.org/show_bug.cgi?id=328576
>     http://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Added keyPressEvent(QKeyEvent* ) for creating shortcut for 'search previous' action (SHIFT+ENTER).
> 
> 
> Diffs
> -----
> 
>   ui/searchlineedit.cpp f4969da 
>   ui/searchlineedit.h 63ff496 
> 
> Diff: https://git.reviewboard.kde.org/r/116578/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Swarn Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140304/0f941718/attachment-0001.html>