[Okular-devel] Review Request 118685: Make tabs rearrangeable

Jonathan Doman jonathan.doman at gmail.com
Thu Jun 12 04:52:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118685/
-----------------------------------------------------------

Review request for Okular.


Bugs: 334018
    http://bugs.kde.org/show_bug.cgi?id=334018


Repository: okular


Description
-------

Catch the tabMoved signal emitted by the tab bar in order to rearrange the internal data. Slightly more than the single line I thought it would be.


Diffs
-----

  shell/shell.h f25b3d8 
  shell/shell.cpp 9ee422a 

Diff: https://git.reviewboard.kde.org/r/118685/diff/


Testing
-------

Tested that the GUI remains coherent when moving two tabs around many times. As before, the tool selections aren't quite coherent, but that's for another patch.


Thanks,

Jonathan Doman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140612/d6e642dd/attachment.html>


More information about the Okular-devel mailing list