[Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

[Albert Astals Cid]

> On jul. 14, 2014, 10:57 p.m., Albert Astals Cid wrote:
> > I'd say we're still leaking m_currentTransition sometimes, like for example
> > 
> > PresentationWidget::slotPrevPage has
> > 
> >         if ( m_transitionTimer->isActive() )
> >         {
> >             m_transitionTimer->stop();
> >             update();
> >         }
> > 
> > so the transition step won't be called and  m_currentTransition won't be deleted. Isn't it easier if you just make it a member variable instead of a pointer so we don't have to worry about it?
> 
> Saheb Preet Singh wrote:
>     Fixed the above said issues.
>     
>     Sir I also wanted to ask you something,
>     its commented in the code // implement missing transitions (a binary raster engine needed here)
>     Am I implementing the feature in a right way ?? Is there any other better way of doing it??

Yes, this is fine, sorry i'm not reviewing fast enough. We are in feature freeze for next release anyway so this can only go into the December release. Will make sure i finish the review before then :)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review62357
-----------------------------------------------------------


On jul. 16, 2014, 7:53 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
> 
> (Updated jul. 16, 2014, 7:53 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 317073
>     http://bugs.kde.org/show_bug.cgi?id=317073
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> implemented fade in and fade out transition for presentation mode in okular.
> 
> 
> Diffs
> -----
> 
>   conf/dlgpresentationbase.ui 31db693 
>   conf/okular.kcfg f980989 
>   ui/presentationwidget.h a99b8ce 
>   ui/presentationwidget.cpp 4aaec2a 
> 
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140730/673d0653/attachment.html>