[Okular-devel] Review Request 118685: Make tabs rearrangeable

[Jonathan Doman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118685/
-----------------------------------------------------------

(Updated July 15, 2014, 9:52 p.m.)


Review request for Okular.


Changes
-------

Whaddya know, there is a KTabWidget::tabBar!


Bugs: 334018
    http://bugs.kde.org/show_bug.cgi?id=334018


Repository: okular


Description
-------

Catch the tabMoved signal emitted by the tab bar in order to rearrange the internal data. Slightly more than the single line I thought it would be.


Diffs (updated)
-----

  shell/shell.h f25b3d8c01215534b9a7097d1e229607c8f98ef3 
  shell/shell.cpp 9ee422a60feb31286abc5ec178ce64835fd80781 

Diff: https://git.reviewboard.kde.org/r/118685/diff/


Testing
-------

Tested that the GUI remains coherent when moving two tabs around many times. As before, the tool selections aren't quite coherent, but that's for another patch.


Thanks,

Jonathan Doman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140716/8c011c19/attachment-0001.html>