[Okular-devel] Review Request 118685: Make tabs rearrangeable

[Albert Astals Cid]

> On jul. 15, 2014, 7:27 p.m., Albert Astals Cid wrote:
> > shell/shell.cpp, line 114
> > <https://git.reviewboard.kde.org/r/118685/diff/1/?file=280425#file280425line114>
> >
> >     What do you mean KTabWidget does not expose the underlying tabbar? KTabWidget is a QTabWidget and is setting its tabbar with 
> >     
> >       setTabBar( new KTabBar( this ) );
> >     
> >     so how would QTabWidget::tabBar not return something valid?
> 
> Jonathan Doman wrote:
>     That function is protected. I would have to subclass {K,Q}TabWidget to gain access to it.

Have you actually tried?

using QTabWidget::tabBar;

in ktabwidget.h should make tabBar public in KTabWidget.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118685/#review62426
-----------------------------------------------------------


On jun. 12, 2014, 4:52 a.m., Jonathan Doman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118685/
> -----------------------------------------------------------
> 
> (Updated jun. 12, 2014, 4:52 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 334018
>     http://bugs.kde.org/show_bug.cgi?id=334018
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Catch the tabMoved signal emitted by the tab bar in order to rearrange the internal data. Slightly more than the single line I thought it would be.
> 
> 
> Diffs
> -----
> 
>   shell/shell.h f25b3d8 
>   shell/shell.cpp 9ee422a 
> 
> Diff: https://git.reviewboard.kde.org/r/118685/diff/
> 
> 
> Testing
> -------
> 
> Tested that the GUI remains coherent when moving two tabs around many times. As before, the tool selections aren't quite coherent, but that's for another patch.
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140715/70281cdb/attachment.html>