[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
-----------------------------------------------------------


"* In scroll mode, now okular can load new page correctly"

What does this mean?


conf/dlgaccessibilitybase.ui
<https://git.reviewboard.kde.org/r/115335/#comment34237>

    Click -> Press? See below



conf/okular.kcfg
<https://git.reviewboard.kde.org/r/115335/#comment34236>

    What About MiddlePress and not MiddleClick? Since it's more about stuff that happens when you press the button and not release it yet more than stuff that happens on click



ui/pageview.h
<https://git.reviewboard.kde.org/r/115335/#comment34234>

    missing "r" in Scoll



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/115335/#comment34235>

    const
    
    Also not sure i like he zoomAllowed name, what about "middlePressZooms"?



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/115335/#comment34238>

    What's the change in this block?



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/115335/#comment34239>

    Since you're repeating these blocks over and over you may want to add it into a quick function maybe, so that if in the future we need to change something we don't mistakingly forget one of the places.



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/115335/#comment34240>

    Can you explain why the need for a timer?



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/115335/#comment34241>

    repaint is a bit bad, does update work?


- Albert Astals Cid


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
>     http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140127/3536fd66/attachment-0001.html>