[Okular-devel] Review Request 110914: Tabbed interface

[Albert Astals Cid]

> On Jan. 15, 2014, 11:33 p.m., Albert Astals Cid wrote:
> > Can you investigate this?
> > 
> > Open two files in two tabs:
> >  * Go to tab 2
> >  * Press Ctrl+F
> >  * Press Esc
> >  * Search bar closes
> >  * Press Ctrl+F
> >  * Go to tab 1
> >  * Go to tab 2
> >  * Press Esc
> >  * Search bar does not close
> >
> 
> Jonathan Doman wrote:
>     As you may have noticed, the problem is that the Part::m_closeFindBar action loses its shortcut (Key_Escape) after switching tabs. However, I can't figure out why this happens. The shortcut seems to be lost/reset after calling createGUI(). Commit f81a49fa (see https://git.reviewboard.kde.org/r/102358/) introduced this behavior, because it moved the shortcut setting from a static initialization in Part::setupViewerAction() to an on/off toggle that happens when the findBar is shown and hidden. For some reason, the static initialization is necessary. If I can figure out how to build kdelibs, I can dig deeper, but this isn't directly related to my tabs code.

What do you mean it's not related to your tabs code? It is something that works without your patch and doesn't work with your patch. So yes it is related to your code. Maybe you need to add more, like tabswitching meaning re-creating the shortcut or something, but it is something that needs to be fixed before we merge this feature in.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review47475
-----------------------------------------------------------


On Jan. 13, 2014, 12:24 a.m., Jonathan Doman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110914/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 12:24 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 155515
>     http://bugs.kde.org/show_bug.cgi?id=155515
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This patch adds support for a tabbed interface (multiple documents in one window). The core work just adds a tab bar that switches between multiple embedded okularparts, but there are many other considerations:
>  - Tab context menu allows for duplicating or detaching (detached tabs start in new okular process)
>  - `okular file.pdf` will open file in existing window if possible, unless --new flag is used. It also selects the most recently raised/activated window to use. This mirrors behavior I expect from browsers and other tabbed interfaces.
>  - Warns when closing window with multiple tabs
>  - No warning is given when opening an already open file. This is the behavior I strongly prefer (and observe in other programs), but will change if there is consensus otherwise.
> 
> When selecting different tools in one part, the tool selection propagates to all parts, but the GUI does not reflect that. This bug is present in other programs (e.g. multiple okularparts in Konqueror), so I made no attempt to diagnose or fix.
> 
> One menu item was added for the multiple tab warning option. When testing this, I noticed that items in the Settings menu seem to move around when switching tabs, and I cannot diagnose or fix this. It seems to be related to XMLGUI bug #64754. 
> 
> My development branch is also hosted at https://github.com/jrmrjnck/okular-tabbed
> 
> 
> Diffs
> -----
> 
>   part.h 4b3aafdb637080ae81eb0e45742f53a34738984d 
>   part.cpp 88e2c41059344dbd11d4c94f99c63a3f5bc8c99b 
>   shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 
>   shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 
>   shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 
> 
> Diff: https://git.reviewboard.kde.org/r/110914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140116/c9ded3e5/attachment.html>