[Okular-devel] Review Request 110914: Tabbed interface

[Jonathan Doman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/
-----------------------------------------------------------

(Updated Jan. 11, 2014, 10:32 p.m.)


Review request for Okular.


Changes
-------

- Use KStandardShortcut functions rather than enum
- Fixed close tab logic
- Check result of closeUrl before closing tabs
- Switch to modified tab when save dialog is shown on exit


Bugs: 155515
    http://bugs.kde.org/show_bug.cgi?id=155515


Repository: okular


Description
-------

This patch adds support for a tabbed interface (multiple documents in one window). The core work just adds a tab bar that switches between multiple embedded okularparts, but there are many other considerations:
 - Tab context menu allows for duplicating or detaching (detached tabs start in new okular process)
 - `okular file.pdf` will open file in existing window if possible, unless --new flag is used. It also selects the most recently raised/activated window to use. This mirrors behavior I expect from browsers and other tabbed interfaces.
 - Warns when closing window with multiple tabs
 - No warning is given when opening an already open file. This is the behavior I strongly prefer (and observe in other programs), but will change if there is consensus otherwise.

When selecting different tools in one part, the tool selection propagates to all parts, but the GUI does not reflect that. This bug is present in other programs (e.g. multiple okularparts in Konqueror), so I made no attempt to diagnose or fix.

One menu item was added for the multiple tab warning option. When testing this, I noticed that items in the Settings menu seem to move around when switching tabs, and I cannot diagnose or fix this. It seems to be related to XMLGUI bug #64754. 

My development branch is also hosted at https://github.com/jrmrjnck/okular-tabbed


Diffs (updated)
-----

  part.h 4b3aafdb637080ae81eb0e45742f53a34738984d 
  part.cpp 05a0a62265c7e7ed79d719a3f648850f8ef642e5 
  shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 
  shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 
  shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 

Diff: https://git.reviewboard.kde.org/r/110914/diff/


Testing
-------


Thanks,

Jonathan Doman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140111/3f841fde/attachment.html>