[Okular-devel] Review Request 114959: The doesConsumeX method was defined but never used

Albert Astals Cid aacid at kde.org
Fri Jan 10 22:32:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114959/#review47170
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On Jan. 10, 2014, 9:33 p.m., Jan Kundrát wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114959/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 9:33 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The doesConsumeX method was defined but never used
> 
> Having functions which are defined but not used serves no gain. This patch
> therefore removes the extra method and updates the comment reference in the
> second one to make it standalone.
> 
> 
> Diffs
> -----
> 
>   core/textpage.cpp c1bd1f2 
> 
> Diff: https://git.reviewboard.kde.org/r/114959/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140110/b2026ca6/attachment.html>


More information about the Okular-devel mailing list