[Okular-devel] Review Request 112370: BugFix for bug 323434/323435

[Tingnan Zhang]

> On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 3594
> > <https://git.reviewboard.kde.org/r/112370/diff/4/?file=220850#file220850line3594>
> >
> >     This 6 and 12 are connected to the 6 and 12 used in PageView::slotRelayoutPages? It'd be great if you could add some static int const for them, previously they were used in a span of 5 lines, but they are very far away from eachotehr now so a proper constant is really welcome

Do you prefer to put the 6 and 12 as static members of the class or to make them global constants of this cpp file? 


> On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4016
> > <https://git.reviewboard.kde.org/r/112370/diff/4/?file=220850#file220850line4016>
> >
> >     What's this for?

This is an unused function. I will delete it.


> On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 3632
> > <https://git.reviewboard.kde.org/r/112370/diff/4/?file=220850#file220850line3632>
> >
> >     Since we only need all these calculations for ZoomIn/Out it'd be good if you could move them inside the case, i.e. have 
> >     
> >     case ZoomIn:
> >     case ZoomOut:
> >     // the code
> >

Sure.


- Tingnan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112370/#review46423
-----------------------------------------------------------


On Nov. 28, 2013, 7:35 a.m., Tingnan Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112370/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 7:35 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> BugFix 323434/323435. Zoom factor now will be properly rounded to those "interval values" like 140%, 250%, etc, when using zoom in and out feature. 
> 
> 
> Diffs
> -----
> 
>   ui/pageview.h 9c15af674e22c2b162fbd330228eb92545cbf805 
>   ui/pageview.cpp 65967bf9399980e89953cce3c6d7145f41155c86 
> 
> Diff: https://git.reviewboard.kde.org/r/112370/diff/
> 
> 
> Testing
> -------
> 
> done on local machine
> 
> 
> Thanks,
> 
> Tingnan Zhang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140110/9fb4af5a/attachment.html>