[Okular-devel] [okular] [Bug 329582] Okular crashes while searching and reloading the PDF simultaneously

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=329582

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |4.12.1
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/okul
                   |                            |ar/9adbd054e4de88de262d7fa8
                   |                            |243ccd73789e2bfc

--- Comment #1 from Albert Astals Cid <aacid at kde.org> ---
Git commit 9adbd054e4de88de262d7fa8243ccd73789e2bfc by Albert Astals Cid.
Committed on 05/01/2014 at 00:26.
Pushed by aacid into branch 'KDE/4.12'.

Do not resetSearch if we're closing down

It's useless as it will be reset anyway on the close down procedure
and it will cause a crash if you are unlucky.

Reason:
  * In the document observers qset pageview comes before
  * We are closing and notifySetup with an empty vector
  * pageview empties its vector in notifySetip
  * part sees the notifySetup and resets the search
  * resetting the search calls another notifySetup with the non empty page
vector
    that will be deleted asap when we go back to the first notifySetup

There are another billion ways to fix this:
 * Don't allow nested notifySetup
 * Clear the running searches before sending the first notifySetup
 * Empty the pagesVector before sending the first notifySetup
 * etc

But i feel this is the less invasive one (even if it may not be the most
technically correct)
FIXED-IN: 4.12.1

M  +4    -0    core/document.cpp

http://commits.kde.org/okular/9adbd054e4de88de262d7fa8243ccd73789e2bfc

-- 
You are receiving this mail because:
You are the assignee for the bug.