[Okular-devel] Review Request 115759: Fix for Bug 326207

[Jaan Vajakas]

> On Feb. 24, 2014, 7:46 p.m., Albert Astals Cid wrote:
> > core/textpage.cpp, line 72
> > <https://git.reviewboard.kde.org/r/115759/diff/3/?file=245466#file245466line72>
> >
> >     Why are these called left/right if we pass top/bottom from the functions below?

My thought was that this methods solves a problem in one-dimensional space and at this point it is not important that these were the projections of rectangles to the y-axis: e. g. the same method could also be called by a hypothetical doesConsumeX method, if we needed one. And endpoints of intervals on the real line are often called left and right (e. g. http://www.proofwiki.org/wiki/Definition:Real_Interval ; also http://en.wikipedia.org/wiki/Interval_%28mathematics%29 uses terms like "left-bounded"). Maybe I should have used the term "closed interval" instead of "segment", since the former seems to be common in English for line segments in one-dimensional space, according to the comment at http://www.encyclopediaofmath.org/index.php/Interval_and_segment .


- Jaan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115759/#review50753
-----------------------------------------------------------


On Feb. 22, 2014, 2:51 p.m., Jaan Vajakas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115759/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 2:51 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 326207
>     http://bugs.kde.org/show_bug.cgi?id=326207
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Here is a patch to fix Bug 326207. It was a simple bug in the XY Cut layout recognition code that made it too eager to see columns everywhere. I also removed the dependence of the layout analysis algorithms on the display DPI (introduced by the recently added feature of using KScreen) to make their behavior more predictable and reproducible. I added tests for this bug and also refactored SearchTest a little to use QVectors instead of bare arrays.
> 
> 
> Diffs
> -----
> 
>   core/textpage.cpp a95f7c6 
>   tests/searchtest.cpp caceb6f 
> 
> Diff: https://git.reviewboard.kde.org/r/115759/diff/
> 
> 
> Testing
> -------
> 
> added automatic tests and tested manually on some PDF files
> 
> 
> Thanks,
> 
> Jaan Vajakas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140225/5c2a2674/attachment.html>