[Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113973/#review50775
-----------------------------------------------------------


I did some changes at http://quickgit.kde.org/?p=okular.git&a=commit&h=11deb53aa5564693c4cb419ea4db2ef0d4a3a3c5 due to the Feature Freeze time pressure, if you disagree or don't understand something do not hesistate to say it!

- Albert Astals Cid


On Feb. 24, 2014, 11:06 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113973/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 11:06 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.
> 
> The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.
> 
> The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.
> 
> So the remaining question is, what is the status of this:
>  core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
> Is someone working on it?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63d2922 
>   conf/okular.kcfg f954c9a 
>   part.rc 0b9cee5 
>   ui/magnifierview.h PRE-CREATION 
>   ui/magnifierview.cpp PRE-CREATION 
>   ui/pageview.h 9c15af6 
>   ui/pageview.cpp 7c7f785 
> 
> Diff: https://git.reviewboard.kde.org/r/113973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140224/7e378382/attachment.html>