[Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

Commit Hook null at kde.org
Mon Feb 24 22:30:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review50771
-----------------------------------------------------------


This review has been submitted with commit 921815b58b80d569284dab53ce83f747aa295363 by Albert Astals Cid on behalf of Saheb Preet Singh to branch master.

- Commit Hook


On Feb. 24, 2014, 9:41 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115072/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 9:41 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 328125
>     http://bugs.kde.org/show_bug.cgi?id=328125
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular don't have any play pause button in the presentation mode.
> 
> Implemented a playpause action in the action collection in part.cpp.
> 
> Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h
> 
> In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon
> 
> When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button.
> 
> 
> Diffs
> -----
> 
>   part.cpp 283e91a 
>   ui/presentationwidget.h c63e119 
>   ui/presentationwidget.cpp 1b63e2f 
> 
> Diff: https://git.reviewboard.kde.org/r/115072/diff/
> 
> 
> Testing
> -------
> 
> tested on local machine, working as desired.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140224/c2fd5a44/attachment-0001.html>


More information about the Okular-devel mailing list