[Okular-devel] Review Request 115925: Change KMessageBox into notifications (PageViewMessage) in dviexport and psgs

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115925/
-----------------------------------------------------------

(Updated Feb. 23, 2014, 6:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Repository: okular


Description
-------

Reduce the number of KMessageBox for information/error and change them into signals for PageViewMessage.
The proper signals are propagated.

Few strings have been adapted or outdated information have been removed.


This is just the beginning of a series of similar cleanup. I'm posting the first one to get feedback on this solution :)


Diffs
-----

  generators/dvi/generator_dvi.cpp c666933 
  generators/dvi/psgs.h 6842a94 
  generators/dvi/psgs.cpp f54d78e 
  generators/dvi/dviexport.cpp c35f4b4 
  generators/dvi/dviRenderer.h 842c11e 
  generators/dvi/dviRenderer.cpp 4513ee2 
  generators/dvi/dviexport.h 3265645 

Diff: https://git.reviewboard.kde.org/r/115925/diff/


Testing
-------

Temporarily remove the dvips executable and try to print a DVI file.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140223/359da2d6/attachment.html>