[Okular-devel] Review Request 115925: Change KMessageBox into notifications (PageViewMessage) in dviexport and psgs

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115925/#review50597
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On Feb. 20, 2014, 9:22 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115925/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 9:22 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Reduce the number of KMessageBox for information/error and change them into signals for PageViewMessage.
> The proper signals are propagated.
> 
> Few strings have been adapted or outdated information have been removed.
> 
> 
> This is just the beginning of a series of similar cleanup. I'm posting the first one to get feedback on this solution :)
> 
> 
> Diffs
> -----
> 
>   generators/dvi/generator_dvi.cpp c666933 
>   generators/dvi/psgs.h 6842a94 
>   generators/dvi/psgs.cpp f54d78e 
>   generators/dvi/dviexport.cpp c35f4b4 
>   generators/dvi/dviRenderer.h 842c11e 
>   generators/dvi/dviRenderer.cpp 4513ee2 
>   generators/dvi/dviexport.h 3265645 
> 
> Diff: https://git.reviewboard.kde.org/r/115925/diff/
> 
> 
> Testing
> -------
> 
> Temporarily remove the dvips executable and try to print a DVI file.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140223/819e1b59/attachment.html>