[Okular-devel] Review Request 115759: Fix for Bug 326207

[Jaan Vajakas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115759/
-----------------------------------------------------------

(Updated Feb. 22, 2014, 2:51 p.m.)


Review request for Okular.


Changes
-------

refactored searchtest.cpp to use more macros, in order to reduce boilerplate code and use QCOMPARE as allowed by the documentation; also fixed bracket style in searchtest.cpp


Bugs: 326207
    http://bugs.kde.org/show_bug.cgi?id=326207


Repository: okular


Description
-------

Here is a patch to fix Bug 326207. It was a simple bug in the XY Cut layout recognition code that made it too eager to see columns everywhere. I also removed the dependence of the layout analysis algorithms on the display DPI (introduced by the recently added feature of using KScreen) to make their behavior more predictable and reproducible. I added tests for this bug and also refactored SearchTest a little to use QVectors instead of bare arrays.


Diffs (updated)
-----

  core/textpage.cpp a95f7c6 
  tests/searchtest.cpp caceb6f 

Diff: https://git.reviewboard.kde.org/r/115759/diff/


Testing
-------

added automatic tests and tested manually on some PDF files


Thanks,

Jaan Vajakas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140222/9cbc398f/attachment.html>