[Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113973/#review50289
-----------------------------------------------------------


Is it working at all? I only get white all the time. 
Also it should be in some menu (probably in Tools), otherwise it gets quite hard to discover

Do you think you can get this done before feature freeze next week?


ui/magnifierview.h
<https://git.reviewboard.kde.org/r/113973/#comment35398>

    You made it an Okular::View but then you don't seem to be using it as a View much, no? You don't implement any of it's virtuals nor register it with the document.



ui/magnifierview.cpp
<https://git.reviewboard.kde.org/r/113973/#comment35400>

    You don't use arg with i18n, you add then as parameters of the i18n call



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/113973/#comment35399>

    Yes, what about remembering the size of last time?



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/113973/#comment35396>

    what's with the context being the same than the text?



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/113973/#comment35397>

    Isn't Ctrl+M default for hide/show menubar?


- Albert Astals Cid


On Nov. 28, 2013, 11:37 a.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113973/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 11:37 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.
> 
> The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.
> 
> The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.
> 
> So the remaining question is, what is the status of this:
>  core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
> Is someone working on it?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 217337f 
>   conf/okular.kcfg deabd07 
>   ui/magnifierview.h PRE-CREATION 
>   ui/magnifierview.cpp PRE-CREATION 
>   ui/pageview.h 9c15af6 
>   ui/pageview.cpp 65967bf 
> 
> Diff: https://git.reviewboard.kde.org/r/113973/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Allow BIG pixmaps
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/20/52c4f894-2286-421e-8025-45027d93524e__01-hack.patch
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140219/d8ae25fb/attachment-0001.html>