[Okular-devel] Review Request 115596: PageViewMessage - support for long messages

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115596/#review49838
-----------------------------------------------------------

Ship it!


Please commit to master (no need for 4.12 here, right?) after fixing the minor issues pointed below


ui/pageviewutils.h
<https://git.reviewboard.kde.org/r/115596/#comment35029>

    const to the function
    
    And the both computeXYZ should probably be private and not protected (is not that we're thinking on someone inheriting from here, no?)



ui/pageviewutils.cpp
<https://git.reviewboard.kde.org/r/115596/#comment35028>

    Please bring the 2 inside the (), make smoe sense



ui/pageviewutils.cpp
<https://git.reviewboard.kde.org/r/115596/#comment35030>

    const for these 3



ui/pageviewutils.cpp
<https://git.reviewboard.kde.org/r/115596/#comment35031>

    add space between | please


- Albert Astals Cid


On Feb. 12, 2014, 11:04 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115596/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 11:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> So far the messages displayed by PageViewMessage are quite short (grep for "emit {error|warning|info}" in the code). The widget does not resize with long messages, nor does it resize on viewparent resize. The patch fixes this (with a bit of heuristic in the calculation of the boundary).
> 
> Side note: I originally thought about porting it to KMessageWidget, but it was more complex (with a different behavior in the end) that fixing it. On the other side, PageViewTopMessage is a better candidate for being ported (it's already used in layouts), but that's another story.
> 
> 
> Diffs
> -----
> 
>   ui/pageviewutils.h bc77cc9 
>   ui/pageviewutils.cpp 3f99248 
> 
> Diff: https://git.reviewboard.kde.org/r/115596/diff/
> 
> 
> Testing
> -------
> 
> Tested normally and --reverse. I will attach a patch that allows to quickly test it.
> 
> 
> File Attachments
> ----------------
> 
> Patch to test the change
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/09/1f06fce0-68d5-4cb1-bd45-a1727e7e3789__test_longmessage.diff
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140215/eaca3799/attachment.html>