[Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

[Michal Humpula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113986/
-----------------------------------------------------------

(Updated Feb. 15, 2014, 2:47 p.m.)


Review request for Okular.


Changes
-------

chnages requsted by Albert + indentation cleanup in document.cpp


Repository: okular


Description
-------

First shot for multiple tiles managers way. Let's face it -- it's nasty. But the compiled okular is displaying my testing pdf without crashing, so at least that.

It's straighforward implementation. Every single place, where there were call for (or with) TilesManager, now has a DocumentObserver as companion. The m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, TilesManager>.

It's adding more code then I expected, but I think that now, when every request can be back-supported by TilesManager, all the request can now be served trought them and not by that direct Pixmap cache in Document. So with that, it would actually be more deletion (imho).


Diffs (updated)
-----

  CMakeLists.txt 217337f 
  conf/okular.kcfg deabd07 
  ui/magnifierview.h PRE-CREATION 
  ui/magnifierview.cpp PRE-CREATION 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/113986/diff/


Testing
-------


Thanks,

Michal Humpula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140215/540bb88b/attachment.html>