[Okular-devel] Review Request 115751: QML PageItem: Handle document path changes

[Marco Martin]

> On Feb. 14, 2014, 7:15 p.m., Marco Martin wrote:
> > looks fine to me (would like a +1 from okular people too tough)
> 
> Albert Astals Cid wrote:
>     I am wondering who sets m_page back to something other than 0, but if you say it works, let's ship it :D

whatever qml client instantiates it it can set the page number to anything


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115751/#review49796
-----------------------------------------------------------


On Feb. 14, 2014, 7:10 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115751/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 7:10 p.m.)
> 
> 
> Review request for Okular and Marco Martin.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
>     QML PageItem: Handle document path changes
> 
>     PageItem works quite well if the DocumentItem has the path on
>     construction, but it does not update if the path is initially blank and
>     then later changed.
> 
> 
> Diffs
> -----
> 
>   active/components/pageitem.h b4fe828 
>   active/components/pageitem.cpp ea5ce10 
> 
> Diff: https://git.reviewboard.kde.org/r/115751/diff/
> 
> 
> Testing
> -------
> 
> Yup. It now works when the path is provided after the DocumentItem's construction.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140214/66f1b681/attachment-0001.html>