[Okular-devel] Review Request 115751: QML PageItem: Handle document path changes

Vishesh Handa me at vhanda.in
Fri Feb 14 19:10:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115751/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 7:10 p.m.)


Review request for Okular and Marco Martin.


Repository: okular


Description
-------

    QML PageItem: Handle document path changes

    PageItem works quite well if the DocumentItem has the path on
    construction, but it does not update if the path is initially blank and
    then later changed.


Diffs
-----

  active/components/pageitem.h b4fe828 
  active/components/pageitem.cpp ea5ce10 

Diff: https://git.reviewboard.kde.org/r/115751/diff/


Testing
-------

Yup. It now works when the path is provided after the DocumentItem's construction.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140214/198494da/attachment.html>


More information about the Okular-devel mailing list