[Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

[Albert Astals Cid]

> On Feb. 9, 2014, 12:04 a.m., Albert Astals Cid wrote:
> > ui/presentationwidget.cpp, line 2120
> > <https://git.reviewboard.kde.org/r/115532/diff/1/?file=242327#file242327line2120>
> >
> >     Do you think you could use m_transitionTimer instead of your own timer?
> 
> Saheb Preet Singh wrote:
>     m_transitionTimer is connected to the slot slotTransitionStep() which only updates some given rects over the screen. Fade transition requires the transparency of m_lastrendered pixmap to be changed instead. How should m_transitiontimer be used ??
>     
>     We could get transition type in some class variable and can switch for the transition type in slottransitionstep for fade in, fade out or default. In default case the slot will behave as before. Should I go in this way??

well slotTransitionStep is "do a step in transition", right now only updates some rects because that is the only thing that was needed, no? If you need it to do something else, make it do something else.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review49311
-----------------------------------------------------------


On Feb. 7, 2014, 8:55 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 8:55 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 317073
>     http://bugs.kde.org/show_bug.cgi?id=317073
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> implemented fade in and fade out transition for presentation mode in okular.
> 
> 
> Diffs
> -----
> 
>   ui/presentationwidget.cpp 1b63e2f 
>   ui/presentationwidget.h c63e119 
> 
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
> 
> 
> Testing
> -------
> 
> It works fine on my system accept for the first time in case of fade out transition.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140213/b150dcb0/attachment.html>