[Okular-devel] Review Request 115596: PageViewMessage - support for long messages

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115596/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 11:04 p.m.)


Review request for Okular.


Changes
-------

Update according the comments. No test available (yet).


Repository: okular


Description
-------

So far the messages displayed by PageViewMessage are quite short (grep for "emit {error|warning|info}" in the code). The widget does not resize with long messages, nor does it resize on viewparent resize. The patch fixes this (with a bit of heuristic in the calculation of the boundary).

Side note: I originally thought about porting it to KMessageWidget, but it was more complex (with a different behavior in the end) that fixing it. On the other side, PageViewTopMessage is a better candidate for being ported (it's already used in layouts), but that's another story.


Diffs (updated)
-----

  ui/pageviewutils.h bc77cc9 
  ui/pageviewutils.cpp 3f99248 

Diff: https://git.reviewboard.kde.org/r/115596/diff/


Testing
-------

Tested normally and --reverse. I will attach a patch that allows to quickly test it.


File Attachments
----------------

Patch to test the change
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/09/1f06fce0-68d5-4cb1-bd45-a1727e7e3789__test_longmessage.diff


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140212/e84eb77a/attachment.html>