[Okular-devel] Review Request 115596: PageViewMessage - support for long messages

[Luigi Toscano]

> On Feb. 9, 2014, 1:45 p.m., Kai Uwe Broulik wrote:
> > > I originally thought about porting it to KMessageWidget, but it was more complex
> > 
> > Wouldn't the free-floating MessageWidget KatePart incorporates, have been suitable for replacing Okular's custom implementation?

That's a bit different: KMessageWidget must be included in a layout, and it produces a resize of the window (different from the really free-floating PageViewMessage), and it needs more refactoring including changes in the kpart. 
Moreover, I discovered this issue while trying to reduce the number of KMessageBox executed by the (old) DVI code (including some code which just exit() in case of error) and I would like to fix this (which includes some string changes) before the freeze for 4.13 (which is quite close).

PageViewTopMessage (used for example for messages related to forms) is more close to the behavior of KMessageWidget.

On the other side we could discuss whether we need two different widget for notification but this "simply" means changing the way the error/warning/info signals are handled.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115596/#review49336
-----------------------------------------------------------


On Feb. 9, 2014, 12:45 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115596/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 12:45 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> So far the messages displayed by PageViewMessage are quite short (grep for "emit {error|warning|info}" in the code). The widget does not resize with long messages, nor does it resize on viewparent resize. The patch fixes this (with a bit of heuristic in the calculation of the boundary).
> 
> Side note: I originally thought about porting it to KMessageWidget, but it was more complex (with a different behavior in the end) that fixing it. On the other side, PageViewTopMessage is a better candidate for being ported (it's already used in layouts), but that's another story.
> 
> 
> Diffs
> -----
> 
>   ui/pageviewutils.h bc77cc9 
>   ui/pageviewutils.cpp 3f99248 
> 
> Diff: https://git.reviewboard.kde.org/r/115596/diff/
> 
> 
> Testing
> -------
> 
> Tested normally and --reverse. I will attach a patch that allows to quickly test it.
> 
> 
> File Attachments
> ----------------
> 
> Patch to test the change
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/09/1f06fce0-68d5-4cb1-bd45-a1727e7e3789__test_longmessage.diff
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140209/c05cf29a/attachment.html>