[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

Yichao Zhou broken.zhou at gmail.com
Tue Feb 4 04:39:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 4:39 a.m.)


Review request for Okular.


Changes
-------

Add "d->mousePressPos = QPoint();" before every "d->middleMouseScrollTimer->stop();"


Bugs: 219121
    http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
-------

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-----

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
-------


Thanks,

Yichao Zhou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140204/a1b8a4dc/attachment.html>


More information about the Okular-devel mailing list