[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Albert Astals Cid]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4485
> > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485>
> >
> >     Can you explain why the need for a timer?
> 
> Yichao Zhou wrote:
>     This is because, in scroll mode, user just moves their mouse a little bit and then does nothing.  The screen will automatically scroll until user exits scroll mode (by another mouse click).
>     
>     In order to let the screen scroll duratively, you will need a timer.

And this is why the whole bug makes no sense. Okular already has a way to scroll that is using the left mouse button. And now you want to make the fact that middle mouse button also scrolls but in a different way. This makes no sense at all. I'm not going to continue reviewing this unless someone explains me why Okular should have two different ways of scrolling.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
-----------------------------------------------------------


On Jan. 28, 2014, 7:02 a.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 7:02 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
>     http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -----
> 
>   conf/dlgaccessibilitybase.ui 9e76a75 
>   conf/okular.kcfg deabd07 
>   ui/pageview.h 9c15af6 
>   ui/pageview.cpp 65967bf 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140203/97c84087/attachment.html>