[Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review72001
-----------------------------------------------------------


Ok, i'm going to apologize here, i did a huge mistake of not checking that there's actually a FadeIn and FadeOut transitions in the PDF spec. And tehre's no, there's just a "Fade" transtition, defined as
"The new page gradually becomes visible through the old one."

Also direction only applies to (Optional; Split, Box and Fly transition styles only) 

The good thing is that you are almost there, the "only" thing you need to do is combine the FadeOut and FadeIn codes in out, and FadeOut the previous page while FadeIn the new page.

Again apologies for not checking what the code should do first and centering on the correctness of the code.

Do you feel like re-writing it like to do FadeOut+FadeIn at the same time?

- Albert Astals Cid


On oct. 10, 2014, 11:24 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
> 
> (Updated oct. 10, 2014, 11:24 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 317073
>     http://bugs.kde.org/show_bug.cgi?id=317073
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> implemented fade in and fade out transition for presentation mode in okular.
> 
> 
> Diffs
> -----
> 
>   conf/dlgpresentationbase.ui 31db693 
>   conf/okular.kcfg f980989 
>   ui/presentationwidget.h a99b8ce 
>   ui/presentationwidget.cpp d994647 
> 
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20141214/2d99ddbd/attachment.html>