[Okular-devel] Review Request 117306: Bug 330518: Add configure icon to the annotation toolbar.

[Albert Astals Cid]

> On mai. 24, 2014, 2:52 p.m., Albert Astals Cid wrote:
> > Hi, could you try to add the button to the "handle" bar as the bug says? Otherwise we're losing quite a bit of space on the bar.
> 
> Abhijeet Nikam wrote:
>     Hi! I thought I had to add a button to the annotation toolbar. I did not understand the term 'handle' bar correctly. Can you just point me to it? I'll add it accordingly.
> 
> Albert Astals Cid wrote:
>     Add an image showing what i mean to the bug itself. Is it clearer now?
> 
> Christoph Feck wrote:
>     Abhijeet, any progress?

Seems not, i'll close it, Abhijeet, if you have time to implement it please file a new review request.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117306/#review58399
-----------------------------------------------------------


On mai. 13, 2014, 6:13 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117306/
> -----------------------------------------------------------
> 
> (Updated mai. 13, 2014, 6:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I have added the the required functionality as a new button in the PageViewToolBar and it opens the annotation settings toolbox on
> clicking it. I have used the help.png in okular/pics for the icon of annotation button for now.
> 
> 
> Diffs
> -----
> 
>   part.h 010e9de 
>   ui/pageviewannotator.h f70eff9 
>   ui/pageviewannotator.cpp 6f2ab38 
>   ui/pageviewutils.h 0772d36 
>   ui/pageviewutils.cpp 96e5f0b 
> 
> Diff: https://git.reviewboard.kde.org/r/117306/diff/
> 
> 
> Testing
> -------
> 
> Tested- Works without giving any error in my system.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20141214/c31877ad/attachment.html>