[Okular-devel] Review Request 121326: initial port of QML components to QtQuick2

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121326/#review71268
-----------------------------------------------------------

Ship it!


We haven't been doing much review of what goes onto the frameworks branch, i had a look at this and doesn't look terrible, so if you have it working, i'd say just commit it :)

- Albert Astals Cid


On des. 2, 2014, 12:08 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121326/
> -----------------------------------------------------------
> 
> (Updated des. 2, 2014, 12:08 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> this is an initial port of the qml component set of okular to qtquick2
> 
> it's straightforward, except pageitem that right now is a qquickpainteditem, that works fine, but a bit slower than generating and uploading the textures by hand (that may be an eventual future port)
> 
> the okular active application is still missing, but the components can be used from anywhere in qml
> 
> 
> Diffs
> -----
> 
>   active/components/okularplugin.cpp a7cbff1 
>   active/components/pageitem.h 932bde3 
>   active/components/pageitem.cpp f9d48f0 
>   active/components/qmldir d62e2ae 
>   active/components/thumbnailitem.h ad3a341 
>   active/components/thumbnailitem.cpp e56170c 
>   CMakeLists.txt d56c02e 
>   active/components/CMakeLists.txt 07eac9b 
>   active/components/documentitem.cpp c8f7ee4 
>   active/components/okularplugin.h c229c53 
> 
> Diff: https://git.reviewboard.kde.org/r/121326/diff/
> 
> 
> Testing
> -------
> 
> files open and render from a simple qml file
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20141202/0ca9e17c/attachment.html>