[Okular-devel] Review Request 119894: Only update zoomFactor for current page
Markus Trippelsdorf
markus at trippelsdorf.de
Fri Aug 22 08:49:49 UTC 2014
> On Aug. 22, 2014, 8:14 a.m., Markus Trippelsdorf wrote:
> > Patch is missing, but the idea sounds right to me.
>
> Albert Astals Cid wrote:
> What do you mean patch is missing?
I didn't see the patch. Why doesn't review-board display it by default?
But never mind, I've now found the "View Diff" link.
- Markus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119894/#review65010
-----------------------------------------------------------
On Aug. 21, 2014, 10:08 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119894/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 10:08 p.m.)
>
>
> Review request for Okular, Markus Trippelsdorf and Tingnan Zhang.
>
>
> Bugs: 335819
> http://bugs.kde.org/show_bug.cgi?id=335819
>
>
> Repository: okular
>
>
> Description
> -------
>
> In the wild world where each page is of different size, only use the current page to update the zoom factor in updateItemSize
>
>
> Diffs
> -----
>
> ui/pageview.cpp 8ceafae
>
> Diff: https://git.reviewboard.kde.org/r/119894/diff/
>
>
> Testing
> -------
>
> Works for me with https://bugs.kde.org/attachment.cgi?id=88318
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140822/dac21404/attachment-0001.html>
More information about the Okular-devel
mailing list