[Okular-devel] Review Request 119737: Fine tune mime type detection used for opening files

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119737/#review64510
-----------------------------------------------------------

Ship it!


The patch looks sane and I didn't spot manifest regressions opening few files.

Sidenote: a broken example DVI file, renamed as .txt, now is opened as plain/text, but it is expected I guess (the info dialog shows it).

- Luigi Toscano


On Ago. 13, 2014, 10:38 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119737/
> -----------------------------------------------------------
> 
> (Updated Ago. 13, 2014, 10:38 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325044
>     http://bugs.kde.org/show_bug.cgi?id=325044
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> If the argument mimetype and filepath mimetype disagree, first try to use the filepath mimetype and if that fails use the argument one. On top of that if text/plain is the first, first try with content mimetype since the text backend never fails to open a file
> 
> 
> Diffs
> -----
> 
>   part.h 19c0d3e 
>   part.cpp d9f1682 
> 
> Diff: https://git.reviewboard.kde.org/r/119737/diff/
> 
> 
> Testing
> -------
> 
> I can now open https://bugs.freedesktop.org/attachment.cgi?id=99508 (which is served as text/plain) and PS files with .txt extension (bug 325044)
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140813/5f5bd675/attachment.html>