[Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review56808
-----------------------------------------------------------


Doesn't compile, and the if warning looks bad too.

/home/kdeunstable/okular/ui/presentationwidget.cpp: In member function ‘const Okular::PageTransition PresentationWidget::defaultTransition(int) const’:
/home/kdeunstable/okular/ui/presentationwidget.cpp:1797:14: error: ‘FadeIn’ is not a member of ‘Okular::Settings::EnumSlidesTransition’
         case Okular::Settings::EnumSlidesTransition::FadeIn:
              ^
/home/kdeunstable/okular/ui/presentationwidget.cpp:1804:7: error: ‘FadeOut’ is not a member of ‘Okular::Settings::EnumSlidesTransition’
  case Okular::Settings::EnumSlidesTransition::FadeOut:
       ^
/home/kdeunstable/okular/ui/presentationwidget.cpp: In member function ‘void PresentationWidget::initTransition(const Okular::PageTransition*)’:
/home/kdeunstable/okular/ui/presentationwidget.cpp:2175:45: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
   if ( ! m_lastRenderedPixmapCopy.isNull() );


- Albert Astals Cid


On March 20, 2014, 9:55 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 9:55 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 317073
>     http://bugs.kde.org/show_bug.cgi?id=317073
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> implemented fade in and fade out transition for presentation mode in okular.
> 
> 
> Diffs
> -----
> 
>   ui/presentationwidget.h a99b8ce 
>   ui/presentationwidget.cpp 4aaec2a 
> 
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
> 
> 
> Testing
> -------
> 
> It works fine on my system accept for the first time in case of fade out transition.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140428/7e07520a/attachment.html>