[Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

[Yichao Zhou]

> On April 8, 2014, 7:47 p.m., Albert Astals Cid wrote:
> > part.cpp, line 388
> > <https://git.reviewboard.kde.org/r/117432/diff/1/?file=263410#file263410line388>
> >
> >     Have you tried if this cause any regressions for the rest of the world that doesn't use okular as you do?

I have updated my patch with some improvements.

1.  Now it still calls setCurrentIndex at startup but with parameter DoNotUncollapseIfCollapsed.  The result should be as same as the previous version but this should be more "conservative" and non-intrusive so that it has less chance to cause regressions.

2.  In setItemEnabled, setCurrentIndex also will be called with DoNotUncollapseIfCollapsed.  This fix the bug when you press F5 or reloading a pdf when you just compile a latex file, the sidebar will flicker (uncollapse and then collapse) if it is collapsed before.

3.  I have added this patch to my Gentoo's user patchset.  I try my best to test it under different situations and have found no side effect for now.  Although I have no ability to test it on every possible environments for the rest of the world.


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117432/#review55241
-----------------------------------------------------------


On April 8, 2014, 9:13 a.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117432/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 9:13 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 201108
>     http://bugs.kde.org/show_bug.cgi?id=201108
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> One line patch:  Do not automatically display thumbnail sidebar in startup.
> 
> 
> Diffs
> -----
> 
>   part.cpp 4ce7e28 
> 
> Diff: https://git.reviewboard.kde.org/r/117432/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140409/f8a2a100/attachment.html>