[Okular-devel] Review Request 111983: Use the de-facto standard shortcut for switching to fullscreen/presentation mode: F11

[Albert Astals Cid]

> On Aug. 12, 2013, 9:22 p.m., Albert Astals Cid wrote:
> > You want to break a shortcut we have been using for more than 4 years? I sincerely don't see how you can think this is a good idea.

No answer means you're not interested in doing any dicussion. Discarding the review.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111983/#review37617
-----------------------------------------------------------


On Aug. 9, 2013, 6:33 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111983/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 6:33 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> When using Okular, I often get caught by trying to use F11 to switch to fullscreen/presentation mode.
> I feel like F11 is more appropriate, as that's what's being used by nearly any application (e.g. Konqueror, Gwenview, …) to switch to fullscreen/presentation mode and is also established outside KDE as shortcut to do this (e.g. any modern browser).
> 
> 
> Diffs
> -----
> 
>   part.cpp 71c3d0f5d908969ffcf18aba327297ccd2e1c8e1 
> 
> Diff: http://git.reviewboard.kde.org/r/111983/diff/
> 
> 
> Testing
> -------
> 
> I've tested this change against 4.10.5 where it worked as expected.
> I wasn't able yet to test it against current 'master', but I don't expect any issues there.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130925/22d1295f/attachment.html>