[Okular-devel] Review Request 113434: Added default shortcut Ctrl + I for change colors.

Ciro Santilli ciro.santilli at gmail.com
Fri Oct 25 16:02:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113434/
-----------------------------------------------------------

Review request for Okular.


Bugs: 173264
    http://bugs.kde.org/show_bug.cgi?id=173264


Repository: okular


Description
-------

Added default shortcut Ctrl + I for change colors.

This should have the exact same of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then clicking Ok, therefore changing the saved configs.

I am not sure if:

- viewport()->update() is the right way to update the screen after this config change? Where is the `update()` method defined? If I tracked well, viewport() returns a DocumentViewport, which does not seem to have such a method.

- I placed the new feature in the right class

but it seems to work.


Diffs
-----

  ui/pageview.h fd4e3ac 
  ui/pageview.cpp a1ab5bd 

Diff: http://git.reviewboard.kde.org/r/113434/diff/


Testing
-------


Thanks,

Ciro Santilli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131025/4d0adb64/attachment.html>


More information about the Okular-devel mailing list