[Okular-devel] Review Request 112370: BugFix for bug 323434/323435

[Tingnan Zhang]

> On Oct. 2, 2013, 11:14 p.m., Albert Astals Cid wrote:
> > Hmmm, i like how now, if i write 154% on there and press the zoom in+zoomout i'm still at 154%, while with your code i'm back to 144%
> > 
> > But not sure if that is of any value but i still like it. What do you guys think, is it valuable?
> 
> Tingnan Zhang wrote:
>     I think with my modification it will go back to 140% (not 144%). 
>     
>     And currently, if you put 194% and press the zoom in + zoom out, you will not get 194%, but 184% instead. Also, if you click zoom in/out when the view is in fit width or fit page mode, you will ended up with some 2-digit precision floating number displayed.
> 
> Jaan Vajakas wrote:
>     I think too that this property (being able to reach the original zoom level by zooming out/in, instead of going to the zoom level drop-down box) would be nice. For the case when the user has entered a custom zoom level, having this behavior and solving bugs 323434/323435 at the same time would make the code more complex (it should then store the original zoom level somewhere). But I think a good compromise would be to guarantee this property only in case the user has selected one of the items from the zoom level menu (one of the percentages or Fit Width or Fit Page). E. g. Adobe Reader has this property.
>

I will check how to calculate the zoom level when Fit Width or Fit Page is selected. 


- Tingnan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112370/#review41149
-----------------------------------------------------------


On Oct. 1, 2013, 11:52 p.m., Tingnan Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112370/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 11:52 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> BugFix 323434/323435. Zoom factor now will be properly rounded to those "interval values" like 140%, 250%, etc, when using zoom in and out feature. 
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 0d6c567d836340555b3101b58178a9247959543a 
> 
> Diff: http://git.reviewboard.kde.org/r/112370/diff/
> 
> 
> Testing
> -------
> 
> done on local machine
> 
> 
> Thanks,
> 
> Tingnan Zhang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131015/b3e6cccc/attachment.html>