[Okular-devel] Review Request 113163: Fix cbr (rar) listing with unrar 5

[Albert Astals Cid]

> On Oct. 9, 2013, 11:55 p.m., Albert Astals Cid wrote:
> >

<tsdgeos> kdepepo: anyway if it works for you (no unrar 5 here), let's commit
<tsdgeos> kdepepo: but maybe add a comment in the code saying // this will break if ever a file with two files and the same name in different subfolders
<tsdgeos> or something like that that makes actual sense in english :D


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113163/#review41473
-----------------------------------------------------------


On Oct. 7, 2013, 11:53 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113163/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 11:53 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325677
>     http://bugs.kde.org/show_bug.cgi?id=325677
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The new unrar version includes the paths in its "bare listing" (unrar lb), while it still extracts only the filename without the path. Thus, the Unrar::list() function fails. This patch strips the path away.
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/unrar.cpp 87f8bbb 
> 
> Diff: http://git.reviewboard.kde.org/r/113163/diff/
> 
> 
> Testing
> -------
> 
> Works with both unrar 4 and unrar 5 on both test archives from bug 325677.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131009/91b41460/attachment-0001.html>