[Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

[Jaan Vajakas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112135/
-----------------------------------------------------------

(Updated Oct. 5, 2013, 8:20 p.m.)


Review request for Okular.


Changes
-------

I updated the tests so that no new external files are needed (I gave up testing Document::searchText and contended myself with testing TextPage::findText only, since I have not changed the Document class; so I could easily use synthetic test pages). By the way, my tests cover Bug 309030 already (testHyphenAtEndOfPage).


Bugs: 323262 and 323263
    http://bugs.kde.org/show_bug.cgi?id=323262
    http://bugs.kde.org/show_bug.cgi?id=323263


Repository: okular


Description
-------

This patch solves Bug 323262 and Bug 323263. I also refactored and simplified the code a little. By removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)). 

(I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.)


Diffs (updated)
-----

  core/textpage_p.h 8ecf0c9 
  core/textpage.cpp 855942d 
  tests/searchtest.cpp 495107d 

Diff: http://git.reviewboard.kde.org/r/112135/diff/


Testing
-------


Thanks,

Jaan Vajakas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131005/6d215a49/attachment.html>