[Okular-devel] Review Request 112370: BugFix for bug 323434/323435

Albert Astals Cid aacid at kde.org
Wed Oct 2 23:14:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112370/#review41149
-----------------------------------------------------------


Hmmm, i like how now, if i write 154% on there and press the zoom in+zoomout i'm still at 154%, while with your code i'm back to 144%

But not sure if that is of any value but i still like it. What do you guys think, is it valuable?

- Albert Astals Cid


On Oct. 1, 2013, 11:52 p.m., Tingnan Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112370/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 11:52 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> BugFix 323434/323435. Zoom factor now will be properly rounded to those "interval values" like 140%, 250%, etc, when using zoom in and out feature. 
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 0d6c567d836340555b3101b58178a9247959543a 
> 
> Diff: http://git.reviewboard.kde.org/r/112370/diff/
> 
> 
> Testing
> -------
> 
> done on local machine
> 
> 
> Thanks,
> 
> Tingnan Zhang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131002/6bcccf42/attachment.html>


More information about the Okular-devel mailing list