[Okular-devel] Review Request 114191: fix parttest not linking against okularpart on msvc

[Patrick Spendrin]

> On Nov. 29, 2013, midnight, Albert Astals Cid wrote:
> > Anyone knows what are the implications of that? Besides it linking on windows :D

MODULEs are not suitable for linkage, there doesn't seem to be any other changes. The only difference is on Windows with gcc as well and this is already handled by kde4_add_plugin.
On *nix modules and shared libraries are both .so's, so there is basically no difference.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114191/#review44753
-----------------------------------------------------------


On Nov. 28, 2013, 11:16 p.m., Nico Kruber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114191/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 11:16 p.m.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> the parttest tries to link against okularpart which does not work on msvc - adding SHARED to the kde4_add_plugin call solves this problem
> 
> kde4_add_plugin(okularpart SHARED ${okularpart_SRCS})
> 
> (developed with Patrick Spendrin)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 217337f 
> 
> Diff: http://git.reviewboard.kde.org/r/114191/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nico Kruber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131129/12495792/attachment.html>