[Okular-devel] Review Request 113978: FB2-module tips on the references to footnotes, finding does footnote.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113978/#review44629
-----------------------------------------------------------


Ok, after you left IRC I thought about it, and it's a reasonable feature if you make it look like

"Go to page %1 (%2)"

Where %2 is some text of where the link will end, maybe it can even be in italics to make that more obvious, of course the text in %2 has to be limited, to not much characters, i'd say 20, anything else makes the tooltip too huge, so if it has more than 20 chars it should be ellided(...) at the end.

But then this kind of makes the use you wanted to use for the feature not really do what you wanted. So I'll leave you choose if you want to implement my suggestion or defend your feature as is now.


core/action.h
<http://git.reviewboard.kde.org/r/113978/#comment31857>

    Please add an @since marker like the one in the function above (but with correct versions 0.19 KDE 4.13)



core/action.h
<http://git.reviewboard.kde.org/r/113978/#comment31856>

    Don't call this a tip, it's not a tip, it's just the text of the file at the viewport destination



core/action.cpp
<http://git.reviewboard.kde.org/r/113978/#comment31858>

    If there is text, make this "Go to page %1 (%2)" where %2 is the text



generators/fictionbook/converter.cpp
<http://git.reviewboard.kde.org/r/113978/#comment31860>

    the indentation here is broken



generators/fictionbook/converter.cpp
<http://git.reviewboard.kde.org/r/113978/#comment31859>

    You should break the for once you found the list node with the id you want


- Albert Astals Cid


On Nov. 21, 2013, 9:17 a.m., Fredy BackSlash wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113978/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 9:17 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> For the module FB2 small refinement to the tips to the references to footnotes, finding does footnote.
> 
> 
> Diffs
> -----
> 
>   core/action.cpp 7c7b09c3eb49eaea0fd1a8242f8cf0fd95e67e0e 
>   core/action.h d089151f36d48074301b6a25fe6088959cd7771e 
>   generators/fictionbook/converter.cpp 9f3ec26d3ecee702c2f8f8a041678826bab2abf5 
> 
> Diff: http://git.reviewboard.kde.org/r/113978/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fredy BackSlash
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131127/ca47347a/attachment-0001.html>