[Okular-devel] Advise needed to fix bug 323434/323435

[Albert Astals Cid]

El Dissabte, 23 de novembre de 2013, a les 01:26:34, Tingnan Zhang va 
escriure:
> Hi everyone:

Hi there-

> 
> I am trying to fix the bug and the review board link is here.
> 
> https://git.reviewboard.kde.org/r/112370
> 
> Now as I am trying to reproduce the behavior of Adobe Reader, I need to
> calculate the zoom value in FitPage/FitWidth mode
> 
> In the current code, the exact zoom factor in those modes is only
> calculated when the function
> 
> slotRelayoutPages()
> 
> is called, which as the name suggests, will also update the page view.

Isn't it in PageView::updateItemSize ?

> 
> 
> My idea is to separate the code that calculates the zoom ratio to a new
> function which can be called at other places.

Looks sensible

Cheers,
  Albert

> 
> Any ideas?
> 
> Tingnan Zhang