[Okular-devel] Review Request 114047: Remove Qt 3 legacy code.

Luigi Toscano luigi.toscano at tiscali.it
Fri Nov 22 22:28:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114047/#review44244
-----------------------------------------------------------


I think it is not needed: the code is not compiled. The kdvi generator is already Qt3-free.

I would prefer to schedule a complete checkup of the dead code instead, but in the meantime this change is not needed.

- Luigi Toscano


On Nov. 22, 2013, 10:23 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114047/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 10:23 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Remove Qt 3 legacy code.
> 
> 
> Diffs
> -----
> 
>   generators/dvi/dviRenderer.cpp 1d17298 
> 
> Diff: http://git.reviewboard.kde.org/r/114047/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131122/9e673013/attachment.html>


More information about the Okular-devel mailing list