[Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

[Azat Khuzhin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/
-----------------------------------------------------------

(Updated May 16, 2013, 11:06 p.m.)


Review request for Okular, Albert Astals Cid and Eike Hein.


Changes
-------

ed7ff8e KFontRequester instead of KFontComboBox for textdocumentsettings
e6a2c83 Add labels for text-document settings


Description
-------

Development history:
https://github.com/azat/okular/compare/master...font-selector-for-plain-text-formats

http://quickgit.kde.org/?p=clones%2Fokular%2Fazatkhuzhin%2Fokular.git&a=commitdiff&h=font-selector-for-plain-text-formats&hp=master
(but it has some delay, about a day or so while this clone will be updated, maybe because of mirrors?)

Link to thread from mailing list:
http://comments.gmane.org/gmane.comp.kde.devel.okular/13279


Diffs (updated)
-----

  CMakeLists.txt 543e6df 
  Mainpage.dox f091e99 
  active/app/package/contents/ui/FullScreenDelegate.qml ac308aa 
  conf/textdocumentsettings.ui PRE-CREATION 
  core/annotations.h 79fd965 
  core/annotations.cpp 353759b 
  core/document.cpp 7cf3461 
  core/textdocumentgenerator.h dd75c5c 
  core/textdocumentgenerator.cpp f370ded 
  core/textdocumentgenerator_p.h 749d6f2 
  core/textdocumentsettings.h PRE-CREATION 
  core/textdocumentsettings.cpp PRE-CREATION 
  core/textdocumentsettings_p.h PRE-CREATION 
  generators/chm/okularApplication_chm.desktop dba7940 
  generators/comicbook/okularApplication_comicbook.desktop 5c98f88 
  generators/djvu/generator_djvu.cpp c506ce3 
  generators/djvu/okularApplication_djvu.desktop e651824 
  generators/dvi/okularApplication_dvi.desktop aab20c2 
  generators/epub/CMakeLists.txt f076ed9 
  generators/epub/generator_epub.h cef2879 
  generators/epub/generator_epub.cpp 59bb2bf 
  generators/epub/libokularGenerator_epub.desktop 5c853a3 
  generators/epub/okularApplication_epub.desktop 8f5ae4c 
  generators/fax/okularApplication_fax.desktop 0938dc6 
  generators/fictionbook/generator_fb.h a898397 
  generators/fictionbook/generator_fb.cpp 2317083 
  generators/fictionbook/libokularGenerator_fb.desktop 099268c 
  generators/fictionbook/okularApplication_fb.desktop 3093146 
  generators/kimgio/okularApplication_kimgio.desktop 218dd82 
  generators/ooo/converter.cpp 1124e2a 
  generators/ooo/generator_ooo.h 3441c7a 
  generators/ooo/generator_ooo.cpp 793ee58 
  generators/ooo/libokularGenerator_ooo.desktop 328ae26 
  generators/ooo/okularApplication_ooo.desktop 960b87a 
  generators/plucker/okularApplication_plucker.desktop bfc03da 
  generators/poppler/annots.cpp 3694188 
  generators/poppler/generator_pdf.cpp 14e92f4 
  generators/poppler/okularApplication_pdf.desktop 17945fa 
  generators/spectre/active-documentviewer_ghostview.desktop ac00065 
  generators/spectre/okularApplication_ghostview.desktop b59b611 
  generators/tiff/okularApplication_tiff.desktop aaed404 
  generators/txt/CMakeLists.txt 473ea12 
  generators/txt/generator_txt.h 5c15ec4 
  generators/txt/generator_txt.cpp 93ca4aa 
  generators/txt/libokularGenerator_txt.desktop 235e23d 
  generators/txt/okularApplication_txt.desktop 3fbee7c 
  generators/xps/okularApplication_xps.desktop 3981a5b 
  part.cpp 59cf514 
  shell/okular.desktop d654cfa 
  tests/modifyannotationpropertiestest.cpp 16d9f9b 
  ui/pagepainter.cpp 2890b56 
  ui/pageviewannotator.cpp 035c1f3 

Diff: http://git.reviewboard.kde.org/r/109021/diff/


Testing
-------

Tested manually


Thanks,

Azat Khuzhin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130516/e71fb6dc/attachment.html>