[Okular-devel] Review Request 110391: Fix for bug 319442

[Jon Mease]

> On May 13, 2013, 6:35 p.m., Fabio D'Urso wrote:
> > Hi Jon! The patch looks good to me. Here are a few minor notes

Thanks Fabio!


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110391/#review32452
-----------------------------------------------------------


On May 13, 2013, 11:06 p.m., Jon Mease wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110391/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 11:06 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Fixed bug 319442 by removing the annotation's inplaceText and window text attributes and replacing them both with the unified usage of the contents attribute.  See discussion with Fabio in bug report and https://git.reviewboard.kde.org/r/107442/.  The inplaceText and window text properties will still be read from saved XML files for backwards compatibility, however they are now used to set the annotation's contents property.
> 
> 
> This addresses bug 319442.
>     http://bugs.kde.org/show_bug.cgi?id=319442
> 
> 
> Diffs
> -----
> 
>   core/annotations.h 4e9082e 
>   core/annotations.cpp 72ca8b5 
>   core/document.cpp 2732441 
>   generators/djvu/generator_djvu.cpp bc83ed7 
>   generators/poppler/annots.cpp b7fb9f7 
>   ui/pagepainter.cpp 950be03 
>   ui/pageviewannotator.cpp 4615d1c 
> 
> Diff: http://git.reviewboard.kde.org/r/110391/diff/
> 
> 
> Testing
> -------
> 
> Tested creating inline note annotations and the bug no longer occurs.
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130513/4c5b2442/attachment.html>