[Okular-devel] Review Request 110419: Set "Save As" default filename point to where the file was opened from

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110419/#review32462
-----------------------------------------------------------

Ship it!


Ok, on a second look, looks fair enough for me, not that i really care.

So please commit, but use urll() instead of url().url() no need to convert from KUrl to QString to KUrl again, no?

- Albert Astals Cid


On May 13, 2013, 7:49 p.m., Fabio D'Urso wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110419/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 7:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Very simple patch that sets default Save As path the same as the path the document has been opened from.
> I've used katepart as reference:
>  https://projects.kde.org/projects/kde/applications/kate/repository/revisions/fbeecb7384e3c3986e8fbafa1123aa422d97e537/entry/part/document/katedocument.cpp#L3832
> 
> Note that this patch does *not* affect Save Copy As.
> 
> 
> This addresses bug 319042.
>     http://bugs.kde.org/show_bug.cgi?id=319042
> 
> 
> Diffs
> -----
> 
>   part.cpp eae6a2f 
> 
> Diff: http://git.reviewboard.kde.org/r/110419/diff/
> 
> 
> Testing
> -------
> 
> I've verified that "Save As" now behaves the same as katepart/kwrite. I've only found a difference in stdin handling.
> 
> $ okular, then open local file from Open menu
>   Defaults to the same path as expected. Obviously same behavior as kwrite.
> 
> $ okular, then open remote HTTP file from Open menu
>   Defaults to the same path, shows a HTTP folder. It's the same behavior as kwrite.
> 
> $ okular /path/to/local/file
>   Defaults to the same path as expected. Obviously same behavior as kwrite.
> 
> $ okular http://remote/file
>   Defaults to local file with the same name. Same behavior as kwrite.
> 
> $ cat /path/to/local/file | okular -
>   Defaults to "-". Note that "kwrite -stdin", instead, shows no default name in this case.
> 
> Bookmarks:
>   I've tested opening bookmarks from local files and it defaulted to the bookmarked path as expected.
>   Opening HTTP bookmarks didn't work (seems we store a wrong URL, but it's not related to this patch)
> 
> okularpart embedded in konqueror:
>   Defaults to local file with the same name. Same behavior as katepart embedded in konqueror.
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130513/a6d19167/attachment.html>