[Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

[Azat Khuzhin]

> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote:
> > Azat you still interested in working on this?
> 
> Azat Khuzhin wrote:
>     Yes, I will try to look at this weekend.
>     I don't have enough time for this at weekdays.
> 
> Azat Khuzhin wrote:
>     Sorry for such a long delay, I have the time for that now.
>     On it.

Albert, Eike, Thanks for ideas!

For now I have _dirty_ patch that implement this in per-backend options.

But here is the thing:
We can't just return QWidget with general properties,
because we want to restore settings for every backend separately,
and we can't do this in current scheme, because this QWidget contain elements with one objectName(),
while we need to change it for backend.

I think even if we do this, this is not transparent.
Also we must generate "*.kcfg[c]" to {re,}store it.

Maybe I misunderstood something?
Any thoughts?


- Azat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review30393
-----------------------------------------------------------


On Feb. 23, 2013, 11:56 a.m., Azat Khuzhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109021/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 11:56 a.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Eike Hein.
> 
> 
> Description
> -------
> 
> Development history:
> https://github.com/azat/okular/compare/master...font-selector-for-plain-text-formats
> 
> Link to thread from mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneralbase.ui f2c9efd 
>   conf/okular_core.kcfg 054b5c1 
>   core/textdocumentgenerator.h dd75c5c 
>   core/textdocumentgenerator.cpp f370ded 
>   core/textdocumentgenerator_p.h 749d6f2 
> 
> Diff: http://git.reviewboard.kde.org/r/109021/diff/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130501/9cfafeeb/attachment.html>