[Okular-devel] Review Request 109633: Use crosshair cursor while annotating

[Peter Grasch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109633/
-----------------------------------------------------------

(Updated March 23, 2013, 9:01 p.m.)


Review request for Okular.


Changes
-------

Okular now shows a "forbidden" cursor when outside the page.

In order to select the correct cursor when annotation tool is selected with a keyboard shortcut (where we can make no assumptions about the mouse position), I had to make pickItemOnPoint public.


Description
-------

The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual "pen tip").

The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture.


Diffs (updated)
-----

  ui/pageview.h 5e839f2 
  ui/pageview.cpp e8d481d 
  ui/pageviewannotator.h 850d887 
  ui/pageviewannotator.cpp 4615d1c 

Diff: http://git.reviewboard.kde.org/r/109633/diff/


Testing
-------

Tested successfully: Tool selection, deselection, continuous mode.


Thanks,

Peter Grasch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130323/50b151c4/attachment.html>