[Okular-devel] Review Request 109633: Use crosshair cursor while annotating

[Fabio D'Urso]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109633/#review29658
-----------------------------------------------------------


A few notes:
 - Until further mouse movement, I keep seeing the crosshair cursor when I'm done making an annotation in non-continuous mode or after closing the annotation toolbar (F6).
 - PageViewAnnotator::active() seems very similar to PageViewAnnotator::routeEvents(). Maybe we can just rename s/routeEvents/active/ ?
 - I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there)

- Fabio D'Urso


On March 21, 2013, 1:22 a.m., Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109633/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 1:22 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual "pen tip").
> 
> The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture.
> 
> 
> Diffs
> -----
> 
>   ui/pageviewannotator.cpp 7bd7496 
>   ui/pageviewannotator.h 850d887 
>   ui/pageview.cpp e8d481d 
> 
> Diff: http://git.reviewboard.kde.org/r/109633/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully: Tool selection, deselection, continuous mode.
> 
> 
> Thanks,
> 
> Peter Grasch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130321/16eb1d40/attachment.html>